Add GTM APIs. by wilcobmsft · Pull Request #5423 · Azure/azure-rest-api-specs

wilcobmsft · 2019-03-19T17:43:36Z

Latest improvements:

Adding GTM APIs. This is an aggregation of all the individual PRs that were sent over the past few months which were reviewed by ARM but marked as [do not merge]:

[DO NOT MERGE] Changes for introduction of transfer products API for Microsoft.Billing #5176
WaitForARMFeedback: Update auto renew policy for support plan api in Microsoft.Billing swagger (Do not merge!) #5028
Swagger for transferring subscription within a commerce root (Do not merge) #4876
[Microsoft.Billing]: Updating swagger with rename changes required. #4495
Microsoft.Billing and Microsoft.Consumption swagger changes for GTM (DoNotMerge) #4484
[Microsoft.Billing]: Updating swagger with rename changes required. #4495

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-03-19T17:44:19Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3853

AutorestCI · 2019-03-19T17:44:34Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#1781

AutorestCI · 2019-03-19T17:44:56Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 172, in rest_handle_action
    return rest_pull_sync(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 200, in rest_pull_sync
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 255, in generate_sdk_from_git_object
    manage_git_folder(gh_token, clone_dir, branched_sdk_git_id) as sdk_folder:
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout master
  stderr: 'fatal: unable to create threaded lstat'

AutorestCI · 2019-03-19T17:45:01Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2360

AutorestCI · 2019-03-19T17:45:35Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3207

azuresdkci · 2019-03-19T17:45:45Z

Can one of the admins verify this patch?

AutorestCI · 2019-03-19T17:45:59Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: dep ensure
Finished with return code 1
and output:

grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export google.golang.org/api: failed to fetch source for https://code.googlesource.com/google-api-go-client: unable to get repository: Cloning into '/tmp/tmpsx_5h_rq/pkg/dep/sources/https---code.googlesource.com-google--api--go--client'...
error: cannot fork() for git-remote-https: No space left on device
: command failed: [git clone --recursive -v --progress https://code.googlesource.com/google-api-go-client /tmp/tmpsx_5h_rq/pkg/dep/sources/https---code.googlesource.com-google--api--go--client]: exit status 255

REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

adxsdknet · 2019-03-19T17:49:46Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5509
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@46faeb5
adxsdknet/azure-sdk-for-net@8475a9f
adxsdknet/azure-sdk-for-net@63c455e
adxsdknet/azure-sdk-for-net@07a1cc4
adxsdknet/azure-sdk-for-net@f1cc81d
adxsdknet/azure-sdk-for-net@335a937
adxsdknet/azure-sdk-for-net@7a15739

...ification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json

REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

jhendrixMSFT · 2019-03-25T17:17:10Z

@AutorestCI regenerate azure-sdk-for-go

REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

wilcobmsft · 2019-03-25T20:44:49Z

The only failing check left at this point is due to an out-of-space error:

error: cannot fork() for git-remote-https: No space left on device

majastrz · 2019-03-25T20:47:19Z

"/providers/Microsoft.Billing/listBillingAccountsWithCreateInvoiceSectionPermission": {

This API doesn't really conform to the ARM RPC. In which of the listed PRs was it approved?

Refers to: specification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json:65 in e51d103. [](commit_id = e51d103, deletion_comment = False)

wilcobmsft · 2019-03-25T20:49:37Z

@majastrz See #4484.

majastrz

Signing off based on the provided summary of changes on top of the aggregation of signed off PRs. Next time, please create a separate branch and do all the incremental work there. It will speed up the review process.

wilcobmsft · 2019-03-25T21:53:56Z

@AutorestCI regenerate azure-sdk-for-go

AutorestCI · 2019-03-25T21:54:02Z

Encountered an unknown error

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/bot_framework.py", line 105, in manage_comment
    response = getattr(self.handler, orderstr)(webhook_data.issue, *split_text)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/restbot.py", line 54, in regenerate
    return self.rebuild(issue, repotag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/restbot.py", line 36, in rebuild
    self.sdk_default_base
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 200, in clone_to_path
    _git_clone_to_path(https_authenticated_url, folder)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/git_tools.py", line 76, in clone_to_path
    repo = Repo.clone_from(https_authenticated_url, str(folder))
  File "/usr/local/lib/python3.6/dist-packages/git/repo/base.py", line 988, in clone_from
    return cls._clone(git, url, to_path, GitCmdObjectDB, progress, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/repo/base.py", line 933, in _clone
    v=True, universal_newlines=True, **add_progress(kwargs, git, progress))
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 735, in execute
    **subprocess_kwargs
  File "/usr/lib/python3.6/subprocess.py", line 709, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.6/subprocess.py", line 1275, in _execute_child
    restore_signals, start_new_session, preexec_fn)
OSError: [Errno 28] No space left on device

* .NET SDK Resource Provider:'Billing' REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit * .NET SDK Resource Provider:'Billing' REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit * .NET SDK Resource Provider:'Billing' REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit * .NET SDK Resource Provider:'Billing' REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit * .NET SDK Resource Provider:'Billing' REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit * .NET SDK Resource Provider:'Billing' REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit * .NET SDK Resource Provider:'Billing' REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

Add GTM APIs.

ffbb8a7

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR billing/resource-manager] Add GTM APIs. Azure/azure-sdk-for-js#1635

Closed

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR billing/resource-manager] Add GTM APIs. Azure/azure-sdk-for-node#4962

Closed

azuresdkci assigned sergey-shandar Mar 19, 2019

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR billing/resource-manager] Add GTM APIs. Azure/azure-sdk-for-ruby#2344

Merged

azuresdkci requested a review from sergey-shandar March 19, 2019 17:44

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR billing/resource-manager] Add GTM APIs. Azure/azure-sdk-for-java#3151

Merged

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 19, 2019

.NET SDK Resource Provider:'Billing'

46faeb5

REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

wilcobmsft added 4 commits March 19, 2019 10:52

Fix errors.

96983ad

Build error fixes.

9f03589

Register new versions in readme.md.

a18df84

Cleanup

9596e3a

wilcobmsft force-pushed the wilcob/gtm branch from 1fe7424 to 9596e3a Compare March 19, 2019 19:33

wilcobmsft added 6 commits March 19, 2019 12:47

More fixes

2a2ef31

Add /operations.

a3b95ea

Fix invoice section create operation.

ea7d442

Remove available balance for the time being.

d4b3867

fix

3e02cb8

build fix

e3b8aaa

wilcobmsft force-pushed the wilcob/gtm branch from 68f6055 to e3b8aaa Compare March 19, 2019 20:26

Separate StatusType enums.

8745db7

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR billing/resource-manager] Add GTM APIs. Azure/azure-sdk-for-python#4614

Merged

nschonni reviewed Mar 21, 2019

View reviewed changes

Fix typos/casings.

eb7c923

This was referenced Mar 22, 2019

[AutoPR billing/resource-manager] Add GTM APIs. Azure/azure-sdk-for-js#1733

Merged

[AutoPR billing/resource-manager] Add GTM APIs. Azure/azure-sdk-for-node#5026

Closed

more typos/casing fixes

f6c76e2

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 22, 2019

.NET SDK Resource Provider:'Billing'

f1cc81d

REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

wilcobmsft added 2 commits March 23, 2019 19:48

Remove bom.

cd2b0f5

Remove duplicate examples.

66fcd6c

AutorestCI mentioned this pull request Mar 25, 2019

[AutoPR billing/resource-manager] Add GTM APIs. Azure/azure-sdk-for-go#4378

Closed

wilcobmsft added 2 commits March 25, 2019 13:05

Add PR Azure@00929e5.

e89d5c8

Add missing parameters/fix casing.

0c43fc1

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 25, 2019

.NET SDK Resource Provider:'Billing'

335a937

REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

Consolidate operationId naming.

1b2e4dd

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 25, 2019

.NET SDK Resource Provider:'Billing'

7a15739

REST Spec PR 'Azure/azure-rest-api-specs#5423' REST Spec PR Author 'wilcobmsft' REST Spec PR Last commit

majastrz added the ARMReviewInProgress label Mar 25, 2019

majastrz approved these changes Mar 25, 2019

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 25, 2019

sergey-shandar approved these changes Mar 25, 2019

View reviewed changes

anthony-c-martin approved these changes Mar 25, 2019

View reviewed changes

sergey-shandar merged commit d15714b into Azure:master Mar 25, 2019

Conversation

wilcobmsft commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

azuresdkci commented Mar 19, 2019

Uh oh!

AutorestCI commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

adxsdknet commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-net

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jhendrixMSFT commented Mar 25, 2019

Uh oh!

wilcobmsft commented Mar 25, 2019

Uh oh!

majastrz commented Mar 25, 2019

Uh oh!

wilcobmsft commented Mar 25, 2019

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

wilcobmsft commented Mar 25, 2019

Uh oh!

AutorestCI commented Mar 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

wilcobmsft commented Mar 19, 2019 •

edited

Loading

AutorestCI commented Mar 19, 2019 •

edited

Loading

AutorestCI commented Mar 19, 2019 •

edited

Loading

AutorestCI commented Mar 19, 2019 •

edited

Loading

AutorestCI commented Mar 19, 2019 •

edited

Loading

AutorestCI commented Mar 19, 2019 •

edited

Loading

AutorestCI commented Mar 19, 2019 •

edited

Loading

adxsdknet commented Mar 19, 2019 •

edited

Loading